Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add staking team to codeowners file #11089

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Sep 6, 2024

Description

Update codeowners file to add staking team and related directories

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@amitabh94 amitabh94 requested a review from a team as a code owner September 6, 2024 18:53
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 changed the title chore: add staking team on codeowners chore: add staking team to codeowners file Sep 6, 2024
@amitabh94 amitabh94 force-pushed the chore/staking-team-codeowners branch from 34149f7 to 6afbbbc Compare September 6, 2024 18:54
@amitabh94 amitabh94 added team-stake No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Sep 6, 2024
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitabh94 amitabh94 merged commit fbd9692 into main Sep 11, 2024
36 checks passed
@amitabh94 amitabh94 deleted the chore/staking-team-codeowners branch September 11, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants