Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new track events for enabling/disabling basic functionality #11088

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Sep 6, 2024

Description

Added new events that track when users enable or disable their basic functionality. The goal is to measure the usage of this feature.

Related issues

Fixes: #3242

Manual testing steps

  1. Go to the Settings screen
  2. Tap on "Security & Privacy" button
  3. Scroll down to the "Privacy" section
  4. In "General", disable and enable the "Basic Functionality" toggle (you will be prompted with bottom sheet modals to confirm these actions)
  5. View new track events in the logs

Screenshots/Recordings

logs

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built branch, run the app, tested changed code)
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes
  • I've verified the necessary testing evidence (recordings and/or screenshots) is included
  • The code follows the project's style guidelines and best practices
  • The changes are adequately documented (comments, JSDoc, README updates if needed)
  • The PR includes appropriate unit and/or integration tests (if applicable)

@vinnyhoward vinnyhoward requested a review from a team as a code owner September 6, 2024 18:36
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 6, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 519347d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cdf640ab-b7b4-4847-b678-1132e54e58b7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 6, 2024
Copy link

sonarqubecloud bot commented Sep 6, 2024

@vinnyhoward vinnyhoward merged commit 6501cbb into main Sep 6, 2024
49 checks passed
@vinnyhoward vinnyhoward deleted the chore-3242-metrics-privacy-basic-func branch September 6, 2024 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.32.0 Issue or pull request that will be included in release 7.32.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants