-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bundle size check #11083
feat: bundle size check #11083
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5472159
to
f29d7ed
Compare
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Looks good. Has it been tested though? |
Quality Gate passedIssues Measures |
Description
Adding additional mechanism to enable JS bundle size comparison between CI runs. For example, on Extension, there is a designated repository https://github.com/MetaMask/extension_bundlesize_stats, used for tracking bundle size over time. The goal is to enable similar capabilities on mobile's CI so that we're able to track bundle size that is mapped to a PR, compare the size relative to main branch, while maintaining the JS bundle size quality gate based on a threshold defined in the MVP task - #10527
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist