Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bundle size check #11083

Merged
merged 23 commits into from
Oct 2, 2024
Merged

feat: bundle size check #11083

merged 23 commits into from
Oct 2, 2024

Conversation

makemesteaks
Copy link
Contributor

@makemesteaks makemesteaks commented Sep 6, 2024

Description

Adding additional mechanism to enable JS bundle size comparison between CI runs. For example, on Extension, there is a designated repository https://github.com/MetaMask/extension_bundlesize_stats, used for tracking bundle size over time. The goal is to enable similar capabilities on mobile's CI so that we're able to track bundle size that is mapped to a PR, compare the size relative to main branch, while maintaining the JS bundle size quality gate based on a threshold defined in the MVP task - #10527

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@makemesteaks makemesteaks requested a review from a team as a code owner September 6, 2024 14:01
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-dev-ops DevOps team label Sep 6, 2024
@bsgrigorov bsgrigorov force-pushed the feat/INFRA-2045-bundle-size branch from 5472159 to f29d7ed Compare September 27, 2024 07:03
@bsgrigorov
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
scripts/push-bundle-size.sh Outdated Show resolved Hide resolved
scripts/push-bundle-size.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
scripts/push-bundle-size.sh Outdated Show resolved Hide resolved
scripts/push-bundle-size.sh Outdated Show resolved Hide resolved
@makemesteaks
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

bsgrigorov and others added 9 commits October 1, 2024 04:23
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
@bsgrigorov bsgrigorov added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 1, 2024
@bsgrigorov bsgrigorov requested a review from a team October 1, 2024 13:50
@legobeat
Copy link
Contributor

legobeat commented Oct 1, 2024

Looks good. Has it been tested though?
Would you be able to post a link to a successful test-run on a fork before merging? Ping me on Slack if you get stuck on any part of testing it!

Copy link

sonarqubecloud bot commented Oct 1, 2024

@bsgrigorov bsgrigorov added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 9bb7ad7 Oct 2, 2024
37 checks passed
@bsgrigorov bsgrigorov deleted the feat/INFRA-2045-bundle-size branch October 2, 2024 08:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants