feat: react native fast crypto for notifications

[Jonathansoufer]

Description

This PR fixes the major blocker for Notifications GOLIVE which was a performance problem when encrypting data on user Storage. Now we pass a native implementation of scrypt to the Profile Sync Controller and then it used instead of the nodeJS implementation.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

Duration: 656003.3725629747ms

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@contentful/content-source-maps@0.11.2	None	0	109 kB	contentful-ecosystem
npm/@metamask/json-rpc-engine@9.0.3	None	0	177 kB	metamaskbot
npm/@metamask/network-controller@20.2.0	environment	0	432 kB	metamaskbot
npm/@metamask/notification-services-controller@0.7.0	network	0	1.21 MB	metamaskbot
npm/@metamask/profile-sync-controller@0.8.0	network	0	1.01 MB	metamaskbot
npm/@metamask/snaps-sdk@6.5.0	network	0	1.31 MB	metamaskbot
npm/@metamask/snaps-utils@8.1.1	network	0	1.29 MB	metamaskbot
npm/@metamask/utils@9.2.1	None	0	695 kB	metamaskbot
npm/contentful-resolve-response@1.9.0	None	0	20.3 kB	whydah-gally
npm/contentful-sdk-core@8.3.1	None	0	90.4 kB	contentful-ecosystem
npm/contentful@10.15.0	environment, eval, filesystem, network	0	5.41 MB	contentful-ecosystem
npm/react-native-fast-crypto@2.2.0	None	0	1.28 MB	swansontec
npm/rfc4648@1.5.3	None	0	19.6 kB	swansontec
npm/type-fest@0.6.0	None	0	29.6 kB	sindresorhus

🚮 Removed packages: npm/@contentful/content-source-maps@0.6.1, npm/@metamask/json-rpc-engine@9.0.2, npm/@metamask/network-controller@20.1.0, npm/@metamask/notification-services-controller@0.2.1, npm/@metamask/profile-sync-controller@0.2.1, npm/@metamask/snaps-sdk@6.2.1, npm/@metamask/snaps-utils@8.0.1, npm/@metamask/utils@9.1.0, npm/contentful-resolve-response@1.8.1, npm/contentful-sdk-core@8.1.2, npm/contentful@10.12.10, npm/type-fest@4.18.3

View full report↗︎

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b068a0d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a457b81-6715-4d13-9f8c-2cd8ca75db0e

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/contentful@10.15.0	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫
Network access	npm/contentful@10.15.0	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/contentful@10.15.0

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 872be08
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0536d36b-977f-4d79-8ccb-501291b3845a

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f1fa3e6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1fe1b687-e09f-41b3-ba11-0def74e1f7be

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
72 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud