test: Update swap test to handle the details modal

[SamuelSalas]

Description

In some occasion, the Swap action detox test fail when trying to inspect the Detail Modal on the Transaction View. The objective for this task would to add some logic so the test could resolve the issue of the detail modal not appearing and making the test fail even thought the swap was successful.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d423fa7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb408c9d-d747-476f-8bc7-d7350b40fd3b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.87%. Comparing base (8dcdd3c) to head (d423fa7).
Report is 36 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11039      +/-   ##
==========================================
+ Coverage   52.75%   52.87%   +0.11%     
==========================================
  Files        1534     1543       +9     
  Lines       36777    36898     +121     
  Branches     4335     4363      +28     
==========================================
+ Hits        19403    19508     +105     
- Misses      16058    16063       +5     
- Partials     1316     1327      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2da90df
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e3a1f738-6c22-49a0-b08d-681cd1dc277f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request