Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated wallet action icons to be light themed #11018

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Sep 4, 2024

Description

This PR seeks to update the wallet action icons to stick to light theme, as requested by design
Figma link: https://www.figma.com/design/HKpPKij9V3TpsyMV1TpV7C/branch/zzP4hBnRgj7XVvQaoSK2my/DS-Components?node-id=28884-165&node-type=CANVAS&t=IV9IBrDoRZwauCar-0

Related issues

Fixes: https://github.com/metamask/metamask-mobile/issues#workspaces/design-system-61e8a2ae77c3a60012e5003c/issues/zh/740

Manual testing steps

  1. Go to Wallet
  2. Click main action button
  3. Toggle to dark mode

Screenshots/Recordings

Before
https://github.com/user-attachments/assets/c1d12a00-8eb9-424e-8b10-01ae7d566fc1

After
https://github.com/user-attachments/assets/9f29bf16-1508-4fdc-9db5-1d5d6b54d66a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Sep 4, 2024
@brianacnguyen brianacnguyen self-assigned this Sep 4, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 4, 2024 04:25
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (8dcdd3c) to head (e499cac).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11018      +/-   ##
==========================================
+ Coverage   52.75%   52.83%   +0.07%     
==========================================
  Files        1534     1542       +8     
  Lines       36777    36886     +109     
  Branches     4335     4361      +26     
==========================================
+ Hits        19403    19488      +85     
- Misses      16058    16070      +12     
- Partials     1316     1328      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 4, 2024
@brianacnguyen brianacnguyen requested review from georgewrmarshall, garrettbear and a team and removed request for georgewrmarshall and garrettbear September 4, 2024 16:53
Copy link
Contributor

github-actions bot commented Sep 4, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: de36492
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/13a4cdc5-5290-4a54-a787-714fc9ed6998

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 🔥

  • Checked action buttons in light and dark mode ✅

Screenshot 2024-09-04 at 1 12 58 PMScreenshot 2024-09-04 at 1 13 09 PM

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2937353
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/42afdda3-cc83-48c0-8637-0a934b310aed

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Sep 4, 2024

@brianacnguyen brianacnguyen merged commit 20cf0ab into main Sep 4, 2024
40 of 41 checks passed
@brianacnguyen brianacnguyen deleted the lightdark/actionbuttons branch September 4, 2024 22:14
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants