-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated wallet action icons to be light themed #11018
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11018 +/- ##
==========================================
+ Coverage 52.75% 52.83% +0.07%
==========================================
Files 1534 1542 +8
Lines 36777 36886 +109
Branches 4335 4361 +26
==========================================
+ Hits 19403 19488 +85
- Misses 16058 16070 +12
- Partials 1316 1328 +12 ☔ View full report in Codecov by Sentry. |
Bitrise❌❌❌ Commit hash: de36492 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…to lightdark/actionbuttons
…/metamask-mobile into lightdark/actionbuttons
Bitrise❌❌❌ Commit hash: 2937353 Note
|
Quality Gate passedIssues Measures |
Description
This PR seeks to update the wallet action icons to stick to light theme, as requested by design
Figma link: https://www.figma.com/design/HKpPKij9V3TpsyMV1TpV7C/branch/zzP4hBnRgj7XVvQaoSK2my/DS-Components?node-id=28884-165&node-type=CANVAS&t=IV9IBrDoRZwauCar-0
Related issues
Fixes: https://github.com/metamask/metamask-mobile/issues#workspaces/design-system-61e8a2ae77c3a60012e5003c/issues/zh/740
Manual testing steps
Screenshots/Recordings
Before
https://github.com/user-attachments/assets/c1d12a00-8eb9-424e-8b10-01ae7d566fc1
After
https://github.com/user-attachments/assets/9f29bf16-1508-4fdc-9db5-1d5d6b54d66a
Pre-merge author checklist
Pre-merge reviewer checklist