Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix swap smoke tests #11001

Merged
merged 7 commits into from
Sep 3, 2024
Merged

test: Fix swap smoke tests #11001

merged 7 commits into from
Sep 3, 2024

Conversation

davibroc
Copy link
Contributor

@davibroc davibroc commented Sep 3, 2024

Description

This is to address the Swap smoke test failures.

The problem happens because:

  • it takes about 15 second for the button to receive the swipe gesture not sure really why. I tried a few things but I cannot seem to change that
  • But the real problem happens when the gas fee start flashing which also happens also around 15 second after the the quite is displayed. During that the swipe button becomes disabled and the swipe gesture doesn’t take effect

Fix in this PR.

  • I have reduced the standard time defined for detox to wait for the elements to be displayed to 10 secs instead of 15.
  • I have added one more swipe gesture as it used to help before

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davibroc davibroc requested a review from a team as a code owner September 3, 2024 14:10
Copy link
Contributor

github-actions bot commented Sep 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davibroc davibroc self-assigned this Sep 3, 2024
@davibroc davibroc added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 3, 2024
Copy link
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davibroc davibroc force-pushed the fix/swap-smoke-tests branch from 95eaedf to a9242c8 Compare September 3, 2024 21:01
Copy link

sonarqubecloud bot commented Sep 3, 2024

@cortisiko cortisiko merged commit fb65dd8 into main Sep 3, 2024
35 checks passed
@cortisiko cortisiko deleted the fix/swap-smoke-tests branch September 3, 2024 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants