Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Metrics on download logs on login screen #10983

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

tommasini
Copy link
Contributor

Description

Metrics on download logs on login screen

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Sep 2, 2024
@tommasini tommasini requested a review from a team as a code owner September 2, 2024 18:21
Copy link
Contributor

github-actions bot commented Sep 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarqubecloud bot commented Sep 2, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tommasini tommasini merged commit c471ef7 into main Sep 3, 2024
35 checks passed
@tommasini tommasini deleted the chore/metrics-download-logs-login branch September 3, 2024 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 3, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants