Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android crash when svgs use the " html entity #10899

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

joaoloureirop
Copy link
Contributor

@joaoloureirop joaoloureirop commented Aug 29, 2024

Description

Avoid crashes on malformed SVGs from URIs that use the HTML entity " instead of "
react-native-svg team acknowledges this parser needs more work to parse HTML entites correctly

Related issues

Fixes: #10614

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@joaoloureirop joaoloureirop self-assigned this Aug 29, 2024
@joaoloureirop joaoloureirop requested a review from a team as a code owner August 29, 2024 15:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 54cabe0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3ad5217-0c2a-491f-ad4b-707643efe9d4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.75%. Comparing base (8dcdd3c) to head (6d60d36).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10899      +/-   ##
==========================================
- Coverage   52.75%   52.75%   -0.01%     
==========================================
  Files        1534     1539       +5     
  Lines       36777    36852      +75     
  Branches     4335     4358      +23     
==========================================
+ Hits        19403    19442      +39     
- Misses      16058    16086      +28     
- Partials     1316     1324       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 730d860
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77eb9bd3-54e1-46a2-8504-9c264f32ebf3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 4, 2024
@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 4, 2024
@chrisleewilcox
Copy link
Contributor

chrisleewilcox commented Sep 4, 2024

@joaoloureirop E2E is failing. Not seeing anything consistent. Probably just run it one more time to be sure.

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 5, 2024
@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d4df34c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29b825c4-68b3-46e5-bb4d-2e1378d930bb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 10, 2024
Copy link
Contributor

github-actions bot commented Sep 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 190ccea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fde29bf4-6837-49ef-8dd6-57afaeaa0021

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@joaoloureirop joaoloureirop merged commit 6b79f64 into main Sep 10, 2024
42 checks passed
@joaoloureirop joaoloureirop deleted the fix/svg-html-entity-decode branch September 10, 2024 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.32.0 Issue or pull request that will be included in release 7.32.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to connect to ENS dapp in mobile browser
6 participants