-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Android crash when svgs use the " html entity #10899
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 54cabe0 Note
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10899 +/- ##
==========================================
- Coverage 52.75% 52.75% -0.01%
==========================================
Files 1534 1539 +5
Lines 36777 36852 +75
Branches 4335 4358 +23
==========================================
+ Hits 19403 19442 +39
- Misses 16058 16086 +28
- Partials 1316 1324 +8 ☔ View full report in Codecov by Sentry. |
Bitrise❌❌❌ Commit hash: 730d860 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@joaoloureirop E2E is failing. Not seeing anything consistent. Probably just run it one more time to be sure. |
Bitrise❌❌❌ Commit hash: d4df34c Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Bitrise✅✅✅ Commit hash: 190ccea Note
|
Quality Gate passedIssues Measures |
Description
Avoid crashes on malformed SVGs from URIs that use the HTML entity
"
instead of"
react-native-svg team acknowledges this parser needs more work to parse HTML entites correctly
Related issues
Fixes: #10614
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist