Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser tab url type #10894

Merged
merged 4 commits into from
Sep 4, 2024
Merged

fix: browser tab url type #10894

merged 4 commits into from
Sep 4, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Aug 29, 2024

Description

  • allow optional link type on new tabs
  • add type in state
  • configure webview depending on type

Related issues

fixes https://github.com/MetaMask/mobile-planning/issues/1560
fixes #10898

Important

Followup issue to create: refactor to remove enzyme and be able to properly test. Current state of the BrowserTab component doesn't allow proper testing. The current snapshot is useless.

Manual testing steps

See related issue

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart self-assigned this Aug 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart force-pushed the 1560_ios_deeplink_cookies branch 2 times, most recently from 5ce22c9 to 28dd8b4 Compare August 29, 2024 12:23
@NicolasMassart NicolasMassart force-pushed the 1560_ios_deeplink_cookies branch from 28dd8b4 to adc28d2 Compare August 29, 2024 12:25
@NicolasMassart NicolasMassart changed the title fix: browser tab url origin fix: browser tab url type Aug 29, 2024
update comments about deeplinks
@NicolasMassart NicolasMassart marked this pull request as ready for review September 3, 2024 14:22
@NicolasMassart NicolasMassart requested review from a team as code owners September 3, 2024 14:22
@NicolasMassart NicolasMassart added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 3, 2024
@NicolasMassart NicolasMassart added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dcb0d3a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a43d7722-69d8-4d53-8a6f-f4dde2b2b2a3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/constants/browser.ts Outdated Show resolved Hide resolved
tommasini
tommasini previously approved these changes Sep 3, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a minor comment!

Copy link

sonarqubecloud bot commented Sep 4, 2024

@sethkfman sethkfman merged commit 3ccc249 into main Sep 4, 2024
34 of 35 checks passed
@sethkfman sethkfman deleted the 1560_ios_deeplink_cookies branch September 4, 2024 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 4, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

fix: browserTab deeplink detection is not for deeplinks only
4 participants