-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: browser tab url type #10894
fix: browser tab url type #10894
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5ce22c9
to
28dd8b4
Compare
28dd8b4
to
adc28d2
Compare
update comments about deeplinks
Bitrise❌❌❌ Commit hash: dcb0d3a Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left a minor comment!
Quality Gate passedIssues Measures |
Description
Related issues
fixes https://github.com/MetaMask/mobile-planning/issues/1560
fixes #10898
Important
Followup issue to create: refactor to remove enzyme and be able to properly test. Current state of the BrowserTab component doesn't allow proper testing. The current snapshot is useless.
Manual testing steps
See related issue
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist