Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable linting Pods and re-organize setup.mjs file #10880

Merged
merged 73 commits into from
Sep 24, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 29, 2024

Description

This PR refactors setup.mjs file with the purpose of:

  1. Moves Gemfile into iOS directory, which is where it belongs since it only relates to iOS. We also updated everywhere that calls bundle install or exec so it's calling it in the ios directory
  2. Run pod install in CI for detecting diffs in Podfile.lock

Because we're now running pod install in the CI, the total ci.yml job time will take longer. However, it still completes before some other tasks such as unit tests. And since it runs in parallel to those, we should not see an increase in total CI run time.

Related issues

Manual testing steps

  • Running yarn setup still works normally when run locally
  • CI passes when run
  • CI fails when Podfile.lock is changed when pod install runs in the CI

Screenshots/Recordings

Before

After

Example of pod file diff detected
https://github.com/MetaMask/metamask-mobile/actions/runs/10746121351/job/29806449687?pr=10880

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners August 29, 2024 01:05
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c930d80
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d74ea28e-fb3a-4a4e-9283-1d0b03ff4bdc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat

This comment was marked as resolved.

scripts/setup.mjs Outdated Show resolved Hide resolved
@Cal-L Cal-L marked this pull request as draft August 29, 2024 05:51
@Cal-L Cal-L changed the title chore: Chore/detect pod diffs chore: Refactor setup.mjs file Aug 29, 2024
@Cal-L Cal-L marked this pull request as ready for review August 29, 2024 20:17
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fc6238f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a25edc8-6da8-4566-8aec-8711ffdd6de1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

legobeat
legobeat previously approved these changes Sep 23, 2024
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: eced61a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a15195b-7889-4b61-b936-1c689e96f2df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

scripts/setup.mjs Outdated Show resolved Hide resolved
Cal-L and others added 2 commits September 23, 2024 17:45
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
@Cal-L Cal-L enabled auto-merge September 24, 2024 00:46
Copy link

@Cal-L Cal-L added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit d2d4dee Sep 24, 2024
35 of 36 checks passed
@Cal-L Cal-L deleted the chore/detect-pod-diffs branch September 24, 2024 01:14
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants