-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable linting Pods and re-organize setup.mjs file #10880
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: c930d80 Note
|
This comment was marked as resolved.
This comment was marked as resolved.
…/detect-pod-diffs
…-mobile into chore/detect-pod-diffs
Bitrise✅✅✅ Commit hash: fc6238f Note
|
Bitrise❌❌❌ Commit hash: eced61a Note
Tip
|
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Quality Gate passedIssues Measures |
Description
This PR refactors setup.mjs file with the purpose of:
Because we're now running pod install in the CI, the total
ci.yml
job time will take longer. However, it still completes before some other tasks such as unit tests. And since it runs in parallel to those, we should not see an increase in total CI run time.Related issues
Manual testing steps
yarn setup
still works normally when run locallyScreenshots/Recordings
Before
After
Example of pod file diff detected
https://github.com/MetaMask/metamask-mobile/actions/runs/10746121351/job/29806449687?pr=10880
Pre-merge author checklist
Pre-merge reviewer checklist