Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing react-native-slider to pod lock file #10845

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 27, 2024

Description

This adds the missing react-native-slider pod to the pod lock file. Original PR from #10694

Related issues

Fixes: #10694

Manual testing steps

  • Running yarn setup shouldn't show diffs in pod lock file

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners August 27, 2024 22:41
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f928e71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a42d9259-9caa-4e7d-a21a-178179ee6d3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a30a493
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/21427e44-3baf-4263-a9df-9c2e3880951a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@legobeat legobeat merged commit 5ddcd6f into main Aug 28, 2024
39 checks passed
@legobeat legobeat deleted the chore/add-missing-slider-pod-lock branch August 28, 2024 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 28, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants