You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores TOU content file so that it's respected by .gitignore. Update CI to call yarn setup --node, which is retains the same optimized performance for CI ~80s for the yarn setup step.
Related issues
Fixes:
Manual testing steps
Run yarn setup, which generates the TOU content file
Notice the generated file isn't showing as a diff
Running the app shows that TOU content still appears
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
Cal-L
changed the title
fix: Ignore terms of use content
fix: Refactor yarn setup in CI to generate terms of use content while retaining performance optimization
Aug 28, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cal-L
added
Run Smoke E2E
tommasini
added
Run Smoke E2E
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.31.0
Description
Ignores TOU content file so that it's respected by .gitignore. Update CI to call
yarn setup --node, which is retains the same optimized performance for CI ~80s for theyarn setupstep.Related issues
Fixes:
Manual testing steps
yarn setup, which generates the TOU content fileScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist