Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "fix: Fixed 17 High Priority Issues - SonarCloud" #10843

Merged
merged 2 commits into from
Aug 27, 2024
Merged

revert: "fix: Fixed 17 High Priority Issues - SonarCloud" #10843

merged 2 commits into from
Aug 27, 2024

Conversation

sethkfman
Copy link
Contributor

Reverts #10635

@sethkfman sethkfman requested review from a team as code owners August 27, 2024 22:34
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Aug 27, 2024
@sethkfman sethkfman changed the title Revert "fix: Fixed 17 High Priority Issues - SonarCloud" revert: "fix: Fixed 17 High Priority Issues - SonarCloud" Aug 27, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 27, 2024
@sethkfman sethkfman requested a review from SamuelSalas August 27, 2024 22:44
SamuelSalas
SamuelSalas previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman requested a review from a team as a code owner August 27, 2024 23:28
@sethkfman sethkfman requested a review from SamuelSalas August 27, 2024 23:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@brianacnguyen brianacnguyen mentioned this pull request Aug 27, 2024
Closed
7 tasks
@brianacnguyen
Copy link
Contributor

Approved RE snapshot updated

Cal-L
Cal-L approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sethkfman sethkfman merged commit 5db2f60 into main Aug 27, 2024
32 of 33 checks passed
@sethkfman sethkfman deleted the revert-10635-devin/fix-sonarcloud-issues/128019/merge branch August 27, 2024 23:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sethkfman @brianacnguyen @Cal-L @SamuelSalas @metamaskbot