chore: @metamask/swaps-controller v9 -> v10 #10743

nikoferro · 2024-08-22T11:49:28Z

Description

This PR includes the necessary changes for the client to work with @metamask/swaps-controller v10.0.0 (https://www.npmjs.com/package/@metamask/swaps-controller/v/10.0.0)

Related PRs
Upgrade controller to BaseController V2 (#277)
Update name of Polygon network token from MATIC to POL (#312)

These changes are needed since swaps-controller v10, will be upgrading to extend from base controller v2, changing the way how controllers interact with each other

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-08-22T11:51:43Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

infiniteflower · 2024-09-04T21:00:06Z

Need to delete the patch introduced in #10960

SwapsController v10 will have this: https://github.com/MetaMask/swaps-controller/pull/312

nikoferro · 2024-09-27T07:48:32Z

Need to delete the patch introduced in #10960

SwapsController v10 will have this: MetaMask/swaps-controller#312

Just updated the PR and removed this.

martahj

Have not QA'd it but code lgtm!

github-actions · 2024-10-04T07:00:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/core/Engine.ts

sonarqubecloud · 2024-10-04T07:12:23Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Daniel-Cross

This looks good but there's little to no checks or tests ran against these new changes.

At the very least, please run E2E smoke tests on the PR. I already added the label, you may need to remove and add again to get it to run.

I would also like to see some test coverage on the changes. At the moment I just have to trust this doesn't break anything.

Also, a few conflicts that need addressing.

github-actions · 2024-11-04T11:38:39Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ba723f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b9c3188b-59f2-449d-a422-f97508f624e2

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

socket-security · 2024-11-19T23:59:18Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/swaps-controller@10.0.0	Transitive: environment, network	`+6`	1.78 MB	metamaskbot

🚮 Removed packages: npm/@metamask/swaps-controller@9.0.12

View full report↗︎

github-actions · 2024-11-20T00:08:32Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 674d260
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd93bb7d-47b7-4c18-b6c1-5a5dbbcb53e0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

infiniteflower · 2024-11-20T00:17:56Z

Tested

sonarqubecloud · 2024-11-20T00:19:50Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Daniel-Cross

Looks good!

jclancy93

Tested locally and everything LGTM!

github-actions bot added the team-swaps label Aug 22, 2024

nikoferro changed the title ~~chore: updates needed to support swaps-controller v10 (WIP)~~ chore: @metamask/swaps-controller v9 -> v10 Aug 22, 2024

nikoferro added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 27, 2024

nikoferro marked this pull request as ready for review September 27, 2024 07:51

nikoferro requested review from a team as code owners September 27, 2024 07:51

martahj previously approved these changes Sep 30, 2024

View reviewed changes

nikoferro dismissed martahj’s stale review via 4e6d979 October 1, 2024 09:54

nikoferro requested a review from a team as a code owner October 1, 2024 09:54

davibroc added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 2, 2024

nikoferro requested a review from martahj October 2, 2024 06:05

martahj previously approved these changes Oct 2, 2024

View reviewed changes

legobeat requested a review from a team as a code owner October 4, 2024 07:00

legobeat reviewed Oct 4, 2024

View reviewed changes

app/core/Engine.ts Show resolved Hide resolved

nikoferro requested a review from legobeat October 6, 2024 16:58

Daniel-Cross added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 16, 2024

Daniel-Cross requested changes Oct 16, 2024

View reviewed changes

mikesposito added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024

tommasini dismissed martahj’s stale review via ba723f3 November 4, 2024 11:37

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024

nikoferro added 8 commits November 19, 2024 18:16

feat: basecontrollerv2 related changes

0873330

chore: real yarn setup on v10

424350b

temp ts fix

daeba9d

file import fix

7daf751

lint fix

db58c3b

fix for missing allowed calls

a58eef3

removed patch

b36e65a

fix for asset overview

3cbf42e

infiniteflower force-pushed the swaps/basecontrollerv2 branch from 1722e2e to 3cbf42e Compare November 19, 2024 23:43

chore: reset yarn lock

0c93b7e

infiniteflower added 2 commits November 19, 2024 19:00

chore: update yarn lock

0534d23

fix: lint error

674d260

infiniteflower added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024

infiniteflower requested a review from Daniel-Cross November 20, 2024 01:30

Daniel-Cross approved these changes Nov 20, 2024

View reviewed changes

jclancy93 approved these changes Nov 20, 2024

View reviewed changes

bergeron approved these changes Nov 20, 2024

View reviewed changes

infiniteflower added this pull request to the merge queue Nov 20, 2024

Merged via the queue into main with commit 9454705 Nov 20, 2024
49 checks passed

infiniteflower deleted the swaps/basecontrollerv2 branch November 20, 2024 19:32

github-actions bot locked and limited conversation to collaborators Nov 20, 2024

metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: @metamask/swaps-controller v9 -> v10 #10743

chore: @metamask/swaps-controller v9 -> v10 #10743

nikoferro commented Aug 22, 2024 •

edited

Loading

socket-security bot commented Aug 22, 2024 •

edited

Loading

infiniteflower commented Sep 4, 2024

nikoferro commented Sep 27, 2024

martahj left a comment

github-actions bot commented Oct 4, 2024

sonarqubecloud bot commented Oct 4, 2024

Daniel-Cross left a comment •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited by metamaskbot

Loading

socket-security bot commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited by metamaskbot

Loading

infiniteflower commented Nov 20, 2024

sonarqubecloud bot commented Nov 20, 2024

Daniel-Cross left a comment

jclancy93 left a comment

chore: @metamask/swaps-controller v9 -> v10 #10743

chore: @metamask/swaps-controller v9 -> v10 #10743

Conversation

nikoferro commented Aug 22, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

socket-security bot commented Aug 22, 2024 • edited Loading

infiniteflower commented Sep 4, 2024

nikoferro commented Sep 27, 2024

martahj left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2024

sonarqubecloud bot commented Oct 4, 2024

Quality Gate passed

Daniel-Cross left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024 • edited by metamaskbot Loading

Bitrise

socket-security bot commented Nov 19, 2024 • edited Loading

github-actions bot commented Nov 20, 2024 • edited by metamaskbot Loading

Bitrise

infiniteflower commented Nov 20, 2024

sonarqubecloud bot commented Nov 20, 2024

Quality Gate passed

Daniel-Cross left a comment

Choose a reason for hiding this comment

jclancy93 left a comment

Choose a reason for hiding this comment

nikoferro commented Aug 22, 2024 •

edited

Loading

socket-security bot commented Aug 22, 2024 •

edited

Loading

Daniel-Cross left a comment •

edited

Loading

github-actions bot commented Nov 4, 2024 •

edited by metamaskbot

Loading

socket-security bot commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited by metamaskbot

Loading