Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Feat/add redux debugger #10739

Merged
merged 9 commits into from
Aug 22, 2024
Merged

feat: Feat/add redux debugger #10739

merged 9 commits into from
Aug 22, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Aug 22, 2024

Description

These changes enables Redux debugging using Flipper

Related issues

Fixes: #10738

Manual testing steps

  • Follow debugging.md instructions to add the redux debugger plugin to Flipper
  • Run the simulator and notice that the plugin automatically picks up Redux actions
  • You can tap on an action to view the state diffs

Screenshots/Recordings

Before

After

Android
Screenshot 2024-08-21 at 3 55 15 PM

iOS
Screenshot 2024-08-21 at 3 57 40 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners August 22, 2024 00:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 22, 2024
Copy link

socket-security bot commented Aug 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/cycle@1.0.3 None 0 8.1 kB dscape
npm/dayjs@1.11.13 None 0 670 kB iamkun
npm/react-native-flipper@0.263.0 None 0 120 kB flipper-bot
npm/redux-flipper@2.0.3 None 0 10.6 kB plwai

🚮 Removed packages: npm/dayjs@1.11.9)

View full report↗︎

Copy link
Contributor

github-actions bot commented Aug 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a74594c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8536f73-9a09-4ff8-acaf-3b85fa8c3eec

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.17%. Comparing base (7ae10e5) to head (a74594c).
Report is 2 commits behind head on main.

Files Patch % Lines
app/store/index.ts 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10739      +/-   ##
==========================================
- Coverage   52.18%   52.17%   -0.01%     
==========================================
  Files        1521     1521              
  Lines       36452    36455       +3     
  Branches     4250     4251       +1     
==========================================
- Hits        19023    19022       -1     
- Misses      16162    16165       +3     
- Partials     1267     1268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini
tommasini previously approved these changes Aug 22, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS AWESOME NEWS!!!

Let's fix the lint issues, but for me it's one big YESSSS

tommasini
tommasini previously approved these changes Aug 22, 2024
Copy link

@Cal-L Cal-L merged commit e53dc5c into main Aug 22, 2024
32 of 33 checks passed
@Cal-L Cal-L deleted the feat/add-redux-debugger branch August 22, 2024 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Redux debugging
4 participants