Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactor AdvancedView.js #10712

Merged
merged 10 commits into from
Aug 21, 2024
Merged

test: Refactor AdvancedView.js #10712

merged 10 commits into from
Aug 21, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Aug 19, 2024 •
edited
Loading

Refactor AdvancedView.js to improve code quality and maintainability.

This PR includes changes to the AdvancedView.js file to remove references to the testHelpers file, update methods to use class properties, and ensure best practices are followed as per the provided guidelines.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added team-ai AI team (for the Devin AI bot) area-qa Relating to QA work (Quality Assurance) labels Aug 19, 2024
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cac5f99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/358bf4f1-3ad6-4988-a24a-eca644252db8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a5a4bcb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac98ed26-325e-4e46-8d10-646019a69929

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko marked this pull request as ready for review August 20, 2024 18:03
@cortisiko cortisiko requested a review from a team as a code owner August 20, 2024 18:03
@cortisiko cortisiko added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 20, 2024
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1080176
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/42658829-905c-44c9-96ab-b6fe8e57f297

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3a6b11f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/876c768d-ca09-4366-a052-c2e2c82574b4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

SamuelSalas
SamuelSalas previously approved these changes Aug 21, 2024
View reviewed changes
e2e/pages/Settings/AdvancedView.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1c5033e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a4f69e3-b3fe-4416-b74a-a8586fa23cf9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko merged commit 7ae10e5 into main Aug 21, 2024
39 checks passed
@cortisiko cortisiko deleted the detox/devin-refactor-N2L branch August 21, 2024 21:59
@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L left review comments

@cortisiko cortisiko cortisiko approved these changes

@SamuelSalas SamuelSalas SamuelSalas left review comments

Assignees
No one assigned
Labels
area-qa Relating to QA work (Quality Assurance) No QA Needed Apply this label when your PR does not need any QA effort. release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ai AI team (for the Devin AI bot)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @cortisiko @SamuelSalas @metamaskbot