Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sdk async key exchange #10695

Merged
merged 29 commits into from
Aug 22, 2024
Merged

feat: sdk async key exchange #10695

merged 29 commits into from
Aug 22, 2024

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Aug 19, 2024

Description

Related issues

Fixes: #10315

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@christopherferreira9 christopherferreira9 added team-sdk SDK team Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 20, 2024
@christopherferreira9 christopherferreira9 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 20, 2024
Copy link

socket-security bot commented Aug 21, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/sdk-communication-layer@0.28.1 None 0 3.16 MB danfinlay, gudahtt, kumavis, ...8 more
npm/utf-8-validate@5.0.10 None 0 403 kB lpinca

🚮 Removed packages: npm/@metamask/sdk-communication-layer@0.20.2), npm/utf-8-validate@6.0.3)

View full report↗︎

Copy link

socket-security bot commented Aug 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/utf-8-validate@5.0.10

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@christopherferreira9 christopherferreira9 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 21, 2024
@abretonc7s
Copy link
Contributor Author

abretonc7s commented Aug 21, 2024

@SocketSecurity ignore npm/utf-8-validate@5.0.10
In the process of fully removing the depency from the communication layer

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 22, 2024
@christopherferreira9
Copy link
Contributor

Full testing strategy and results here.

@christopherferreira9 christopherferreira9 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 586c4b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b35f15c-d2f5-4b50-8c89-fac53734c9db

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

index.js Show resolved Hide resolved
@christopherferreira9
Copy link
Contributor

E2E are currently experiencing flaky results:
The first run had 4 tests failing: https://app.bitrise.io/build/b1fb0923-0428-4e22-815d-d4b9b7ef6989
The second run had only 2 tests failing: https://app.bitrise.io/build/0bab6409-fa2a-42b1-9922-ed93b7809406

No fixes were done in between the two runs

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA in Progress QA has started on the feature. Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d2f6ce0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6365f89-7c23-42aa-871e-760323463667

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@christopherferreira9
Copy link
Contributor

@christopherferreira9 christopherferreira9 merged commit 8d40457 into main Aug 22, 2024
32 of 33 checks passed
@christopherferreira9 christopherferreira9 deleted the asynckeyexchange branch August 22, 2024 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 22, 2024
@christopherferreira9 christopherferreira9 added release-7.30.0 Issue or pull request that will be included in release 7.30.0 and removed release-7.31.0 Issue or pull request that will be included in release 7.31.0 labels Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong origin on confirmation screens
5 participants