-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: camera permission alert with settings access #10673
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated copy/design here |
Bitrise❌❌❌ Commit hash: 09e9241 Note
|
Bitrise✅✅✅ Commit hash: 58585af Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, approved!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! PR description is a thing of beauty! One non-blocking comment to check with our content design team.
- Checked manual testing steps locally ✅
I noticed that once we have completed the steps the simulator will still not open the camera but I'm assuming that is expected behavior of the simulator
Description
This pull request addresses an issue related to camera permissions during the initial wallet setup in the app. The improvement provides a better user experience for those who initially deny camera access but later wish to use the QR scanning functionality.
implemented a solution to improve the user experience when dealing with camera permissions:
Replaced the old alert with a new, informative message when users attempt to use the QR scanner after initially denying permission.
Added functionality to route users directly to their system settings to modify camera permissions.
Enhanced user experience by providing a clear path to enable necessary app functionality.
Related issues
Fixes: Issue #10642
Manual testing steps
Screenshots/Recordings
iOS
Android
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist