Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera permission alert with settings access #10673

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Aug 15, 2024

Description

This pull request addresses an issue related to camera permissions during the initial wallet setup in the app. The improvement provides a better user experience for those who initially deny camera access but later wish to use the QR scanning functionality.

implemented a solution to improve the user experience when dealing with camera permissions:

  1. Replaced the old alert with a new, informative message when users attempt to use the QR scanner after initially denying permission.

  2. Added functionality to route users directly to their system settings to modify camera permissions.

  3. Enhanced user experience by providing a clear path to enable necessary app functionality.

Related issues

Fixes: Issue #10642

Manual testing steps

  1. Fresh install the MetaMask mobile app.
  2. Complete the initial wallet setup.
  3. Tap the QR scanner icon in the top right corner.
  4. When prompted "MetaMask Would Like to Access the Camera", select "Don't Allow".
  5. Attempt to use the QR scanner again by tapping the icon.
  6. Verify that the new alert appears with options to cancel or open settings.
  7. Test that the "Open Settings" option correctly routes to the system settings.
  8. Enable camera permissions in settings and return to the app.
  9. Confirm that the QR scanner now functions correctly.

Screenshots/Recordings

iOS

Before After
before after

Android

Before After
before_android_compressed after_android_compressed

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward changed the title Fix: Camera Permission Alert with Settings Access fix: camera permission alert with settings access Aug 15, 2024
@yanrong-chen
Copy link

yanrong-chen commented Aug 16, 2024

Updated copy/design here
Screenshot 2024-08-16 at 10 47 50 AM

@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 16, 2024
@vinnyhoward vinnyhoward marked this pull request as ready for review August 16, 2024 18:11
@vinnyhoward vinnyhoward requested a review from a team as a code owner August 16, 2024 18:11
Copy link
Contributor

github-actions bot commented Aug 16, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 09e9241
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd985995-ef9e-4c2a-938f-640bbecf2b05

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 16, 2024
Copy link
Contributor

github-actions bot commented Aug 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 58585af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e04e5a35-9aa5-4be2-9a23-592124d38e2d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 16, 2024
@EtherWizard33 EtherWizard33 self-requested a review August 20, 2024 08:18
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, approved!

@vinnyhoward vinnyhoward added the Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild label Aug 20, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! PR description is a thing of beauty! One non-blocking comment to check with our content design team.

  • Checked manual testing steps locally ✅

I noticed that once we have completed the steps the simulator will still not open the camera but I'm assuming that is expected behavior of the simulator

after.mov

locales/languages/en.json Show resolved Hide resolved
@vinnyhoward vinnyhoward merged commit 1d6c823 into main Sep 5, 2024
37 checks passed
@vinnyhoward vinnyhoward deleted the fix-10642-camera-permissions-ux branch September 5, 2024 14:56
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 5, 2024
@vinnyhoward vinnyhoward removed the Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild label Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Camera Permission Denial Leads to Poor User Experience with No Easy Way to Fix
6 participants