Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick 2df9eb5 #10669

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore: cherry pick 2df9eb5 #10669

merged 1 commit into from
Aug 15, 2024

Conversation

sethkfman
Copy link
Contributor

Description

This PR cherry pick 2df9eb5 for a swaps bug.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-swaps labels Aug 15, 2024
@sethkfman sethkfman requested review from a team as code owners August 15, 2024 20:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/swaps-controller@9.0.2 None 0 228 kB gudahtt

🚮 Removed packages: npm/@metamask/swaps-controller@9.0.1

View full report↗︎

@sethkfman sethkfman merged commit 0ca2742 into release/7.28.1 Aug 15, 2024
36 of 37 checks passed
@sethkfman sethkfman deleted the cherry-pick-2df9eb5 branch August 15, 2024 20:35
Copy link

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants