Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notifications first round of tests #10668

Merged
merged 19 commits into from
Aug 16, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Aug 15, 2024

Description

This PR introduces smalls fixes on Notifications feature after the first round of tests.

[x] - Error when enabling Notifications due embedded Snap Execution Environment. Changed to use external URL.
[x] - Misalignment on UI components like Loading and Notifications Header.
[x] - Bug Cannot update a component while rendering a different component due unnecessary usage of navigationsOptions on Notifications Details page.
[x] - Fix async dependency on Notification Enable toggle & Alert.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team labels Aug 15, 2024
@Jonathansoufer Jonathansoufer self-assigned this Aug 15, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners August 15, 2024 20:17
@Jonathansoufer Jonathansoufer changed the title Fix/notifications first round of tests fix: notifications first round of tests Aug 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Aug 15, 2024
Copy link
Contributor

github-actions bot commented Aug 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 59f2c59
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bea2c8ed-d75e-4737-aef5-c37818afd8ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini
Copy link
Contributor

Unit tests are failing!

Can you update the description with what the issues that were discovered and what the PR is aiming to fix? It will help the reviews

tommasini
tommasini previously approved these changes Aug 15, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tommasini
tommasini previously approved these changes Aug 16, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner August 16, 2024 16:07
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/snaps-execution-environments@6.6.2 None 0 5.64 MB metamaskbot

🚮 Removed packages: npm/@metamask/snaps-execution-environments@6.5.0

View full report↗︎

Copy link

@Jonathansoufer Jonathansoufer merged commit d05aeb1 into main Aug 16, 2024
32 of 33 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/notifications-first-round-of-tests branch August 16, 2024 17:42
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants