fix: issue in blockaid spinner for batched confirmations

[jpuri]

Description

Bloackaid spinner is not shown correctly when confirmation requests are batched.

Previously we only kept result of blockaid validation for only current transaction in redux state, this PR makes change to keep validation result of all recent transaction in state.

Related issues

Fixes: #10514

Manual testing steps

1. Go to test dapp
2. Submit batched malicious request
3. Blockaid alert banner should appear correctly

Screenshots/Recordings

Screen.Recording.2024-08-15.at.6.14.48.PM.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2108e33
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16a25ec8-e5de-44a7-b61c-4de712b5f141

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e7c96af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5bd773db-af6c-48ef-8542-dd2f0714f3fb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sleepytanya]

Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce7aed75-1bea-4174-809c-3d7fbe24c12e?tab=artifacts
@jpuri @bschorchit Looks great to me! Spinner is visible all the time while waiting for the warning.

Android:

android.mp4

iOS:

ios.mov

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a54f016
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d8a633a-86a3-42d7-aada-e03855f136ed

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud