chore: confirmations directory ts coverage

[tommasini]

Description

This PR aims to solve and expect the confirmations folder issue, so we can enable confirmations folder and next typescript files can detect typescript issues

Files with issues to solve:

app/components/Views/confirmations/SendFlow/AddressList/AddressList.tsx
app/components/Views/confirmations/SendFlow/Confirm/components/CustomGasModal/CustomGasModal.tsx
app/components/Views/confirmations/components/ApproveTransactionHeader/ApproveTransactionHeader.tsx
app/components/Views/confirmations/components/ApproveTransactionReview/AddNickname/index.tsx
app/components/Views/confirmations/components/ApproveTransactionReview/index.test.tsx
app/components/Views/confirmations/components/EditGasFee1559Update/index.tsx
app/components/Views/confirmations/components/EditGasFeeLegacyUpdate/index.tsx
app/components/Views/confirmations/components/TransactionReview/TransactionReviewEIP1559Update/index.test.tsx
app/components/Views/confirmations/components/TransactionReview/TransactionReviewEIP1559Update/index.tsx
app/components/Views/confirmations/components/TransactionReview/TransactionReviewEIP1559Update/styles.ts
app/components/Views/confirmations/components/TransactionReview/index.test.tsx
app/components/Views/confirmations/components/UpdateEIP1559Tx/index.tsx

Before ts issues:
Found 462 errors in 134 files.

After ts issues:
Found 334 errors in 114 files.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 31fda34
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97442105-aa7d-4042-8318-6163382db0da

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2d4a033
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/21b0d96c-07bc-42d9-80ec-8bdc18341ad1

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/semver@7.6.3	None	0	95.8 kB	npm-cli-ops

🚮 Removed packages: npm/semver@7.6.2

View full report↗︎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM. Btw are the yarn lock changes for deduping?

[tommasini]

Yes!