Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hold to reveal UI/UX #10607

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: hold to reveal UI/UX #10607

merged 2 commits into from
Aug 13, 2024

Conversation

gantunesr
Copy link
Member

Description

This PR fixes the UI/UX related to "Hold to reveal"

Related issues

Fixes: NA

Manual testing steps

  1. Go to the Security & Privacy view
  2. Try to reveal the SRP and/or Private Key
  3. Verify that the hold to reveal UI/UX is fixed

Screenshots/Recordings

Before

Dark mode Light mode
RPReplay_Final1723579466.MP4
RPReplay_Final1723579404.MP4

After

Dark mode Light mode
RPReplay_Final1723577238.MP4
RPReplay_Final1723577401.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-accounts labels Aug 13, 2024
@gantunesr gantunesr marked this pull request as ready for review August 13, 2024 20:14
@gantunesr gantunesr requested a review from a team as a code owner August 13, 2024 20:14
Copy link

@gantunesr gantunesr added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5698427
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e57fe31d-6663-46e4-be50-4219713c3a12

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gantunesr gantunesr merged commit a42d97f into main Aug 13, 2024
43 of 48 checks passed
@gantunesr gantunesr deleted the fix/hold-to-reveal-ui branch August 13, 2024 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 13, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-accounts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants