fix: App crashes when deleting browser favorites on android devices

[Daniel-Cross]

Description

Added a resolve() to the metamask_removeFavorite function to stop Hermes from crashing when trying to handle the Promise.

Hermes would crash when trying to handle the Promise of the Alert method. Adding a resolve() fixes this issue and stops the app from crashing.

Related issues

Fixes: #10583

Manual testing steps

1. Go to the web browser and visit a random website of your choosing.
2. Add said site to favourites (or favorites if you're based in North America).
3. Go back to favourites tab and delete the bookmark you just added.
4. Observe that an alert is displayed and the app does not crash to desktop.

Screenshots/Recordings

Before

357208383-a1358227-d735-4136-8b80-c7c837cef5d4.mov

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ccf3552
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52fb89a6-e456-44ef-94a2-3993ef51b004

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sethkfman]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2201211
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3f7bd02-e398-4ba4-844c-71da37232bf3

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request