Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release action #10531

Merged
merged 3 commits into from
Aug 1, 2024
Merged

chore: fix release action #10531

merged 3 commits into from
Aug 1, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Aug 1, 2024

Description

The current release action fails due when it tries to push the changelog updates to the protected release branch.

It also updates the build_all_targets_pipeline to start QA and Prod builds at the same time instead of staggering them.

Related issues

Fixes: AN

Manual testing steps

  1. NA

Screenshots/Recordings

NA

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested review from a team as code owners August 1, 2024 21:44
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 1, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Aug 1, 2024

@sethkfman sethkfman merged commit d7586ee into main Aug 1, 2024
33 checks passed
@sethkfman sethkfman deleted the chore/fix-release-action branch August 1, 2024 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.29.0 Issue or pull request that will be included in release 7.29.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants