Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multichain popular network dapp connection confirmation bottomsheet #10519

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Aug 1, 2024

Description

It's rather simple all it does is modify the content of an existing screen.
And it does so behind a feature flag, meaning it keeps the previous UI when the flag is false, and shows the modified version if the flag is true.

Related issues

Contributes to solve issue https://github.com/MetaMask/MetaMask-planning/issues/2803

Manual testing steps

  1. from a dapp tab, in the dapp, switch network to polygon
  2. the bottom sheet seen below will show

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18 at 3 56 43 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 27661cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb95f343-0ca0-4a32-9011-421aad3e7e60

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a1f417f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d19cc25-4bde-45cf-8dc7-187078d09c02

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 marked this pull request as ready for review August 1, 2024 19:04
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner August 1, 2024 19:04
Copy link

sonarqubecloud bot commented Aug 2, 2024

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I think adding a test would help

@EtherWizard33
Copy link
Contributor Author

Looks good. I think adding a test would help

Hi Mircea, for this feature, like for the network UI redesign me and Salim from assets worked on last month, David Walsh wants us to write e2e and unit test at the end, before removing the the feature flag, this way the code is done and stable and any unecessary e2e tests and unit tests are removed/replaced at the same time. And the added advantage is that any existing unit tests, including snapshots, ensure that the UI when feature flag is off, does not change until we are ready to move from the old code to the new.

David is OOO this week and not there to explain this reasoning more in detail, but we did this for the network ui redesign also, still behind feature flag.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f3e5853
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aefcf283-1468-4e6a-9548-308e52947f60

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@EtherWizard33 EtherWizard33 merged commit dd4eb7c into main Aug 2, 2024
39 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-2803-multichain-popular-network-dapp-connection-confirmation-bottomsheet branch August 2, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants