-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add primary currency to user object in MetaMetrics #10490
chore: Add primary currency to user object in MetaMetrics #10490
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: e981b5a Note
|
Bitrise✅✅✅ Commit hash: b988945 Note
|
Bitrise❌❌❌ Commit hash: f7b857d Note
|
Bitrise❌❌❌ Commit hash: e52cf4d Note
|
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10490 +/- ##
==========================================
+ Coverage 49.78% 50.59% +0.80%
==========================================
Files 1437 1506 +69
Lines 34762 35914 +1152
Branches 3921 4121 +200
==========================================
+ Hits 17307 18171 +864
- Misses 16354 16585 +231
- Partials 1101 1158 +57 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: bd40405 Note
|
hey @gambinish , can you pls create a github issue ( with the same description than the Jira ) and attach it on this PR. |
Added. Is this needed for every mobile PR? |
Description
Attaches the primary currency selection from Settings to the user object and emits a new event. Will also need to be tracked in the extensions repo (PR coming soon)
Related issues
Fixes: MMASSETS-283
Github Issue: #10573
Manual testing steps
Fiat
andNative
currency togglesScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist