Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add primary currency to user object in MetaMetrics #10490

Merged

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jul 30, 2024

Description

Attaches the primary currency selection from Settings to the user object and emits a new event. Will also need to be tracked in the extensions repo (PR coming soon)

Related issues

Fixes: MMASSETS-283

Github Issue: #10573

Manual testing steps

  1. Go to settings page
  2. Toggle Fiat and Native currency toggles
  3. Validate that events are being emitted as expected

Screenshots/Recordings

Screenshot 2024-07-30 at 4 20 52 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-assets Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 30, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jul 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e981b5a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94252a46-618b-45f0-9a8e-fed18246f865

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish marked this pull request as ready for review July 31, 2024 01:41
@gambinish gambinish requested a review from a team as a code owner July 31, 2024 01:41
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b988945
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a9c2bf8-a840-4bf2-b073-fcbcd8fd355a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f7b857d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5312b7a0-59d5-4e40-9934-0fd037265e44

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e52cf4d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0f9b8c6-4c19-4c95-b665-daf95739ff9d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (4b9f31c) to head (bd40405).
Report is 70 commits behind head on main.

Files Patch % Lines
...components/Views/Settings/GeneralSettings/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10490      +/-   ##
==========================================
+ Coverage   49.78%   50.59%   +0.80%     
==========================================
  Files        1437     1506      +69     
  Lines       34762    35914    +1152     
  Branches     3921     4121     +200     
==========================================
+ Hits        17307    18171     +864     
- Misses      16354    16585     +231     
- Partials     1101     1158      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd40405
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f7380af9-6f1b-41d1-8c8f-83e5c5d4deea

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 31, 2024
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
@gambinish gambinish requested a review from sahar-fehri July 31, 2024 20:45
@gambinish gambinish requested a review from salimtb August 12, 2024 14:27
@salimtb
Copy link
Contributor

salimtb commented Aug 12, 2024

hey @gambinish , can you pls create a github issue ( with the same description than the Jira ) and attach it on this PR.
for mobile this is the standard we follow

@gambinish
Copy link
Contributor Author

hey @gambinish , can you pls create a github issue ( with the same description than the Jira ) and attach it on this PR. for mobile this is the standard we follow

Added. Is this needed for every mobile PR?

@gambinish gambinish merged commit fdb3eba into main Aug 12, 2024
57 checks passed
@gambinish gambinish deleted the chore/mmassets-283_fiat-crypto-currency-toggle-analytics branch August 12, 2024 19:00
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants