Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notifications' details screen #10451

Merged
merged 17 commits into from
Jul 31, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Jul 27, 2024

Description

This PR are part of a series of PRs to implement the new notifications feature on MetaMask. This brings UI elements together to present our users:

  • Notification DETAILS Screen

Related issues

Fixes:

Manual testing steps

  1. Go to this Settings screen, open the new Notifications option and enable it.
  2. Go to main screen, click on the bell icon
  3. See the empty screens.
  4. Perform any onChain transaction
  5. Click on the Notification and see its details

Screenshots/Recordings

NotificationsDemo.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Jul 27, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 27, 2024
Copy link

socket-security bot commented Jul 28, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/react-native-render-html@6.3.4 🚫
[**View full report↗︎**](https://socket.dev/dashboard/org/MetaMask/diff/b31834fd-c765-43af-97b3-cd106ac3c0f3/b28690c8-b50a-4988-b0fa-792a358181eb) ### Next steps
What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/react-native-render-html@6.3.4

@Jonathansoufer Jonathansoufer added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team labels Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b020eb3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a152b24b-3e1f-4a91-9dc8-44a46aa04610

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer changed the title chore: add details screen/ui elements feat: add notifications' details screen Jul 29, 2024
@Jonathansoufer Jonathansoufer marked this pull request as ready for review July 29, 2024 10:09
@Jonathansoufer Jonathansoufer requested review from a team as code owners July 29, 2024 10:09
@Jonathansoufer Jonathansoufer removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 29, 2024
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0e7733e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e4a4324-3880-4b8e-a561-825d86c9ec6b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

app/components/Views/Notifications/Details/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually the unit tests are failing, let's address that as well

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e1daaa8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2bad12e-0430-499f-b87c-796bd84a1d10

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Jonathansoufer Jonathansoufer merged commit bb03051 into main Jul 31, 2024
32 of 33 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-notifications-details-screen branch July 31, 2024 16:46
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants