Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix long press login on samsung devices #10436

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jul 26, 2024

Description

Fix long press on samsung devices!

Related issues

Fixes:

Manual testing steps

  1. Go to login screen
  2. long press 10 seconds fox icon
  3. must allow download state logs

Screenshots/Recordings

Screen.Recording.2024-07-26.at.11.41.31.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform release-7.28.0 Issue or pull request that will be included in release 7.28.0 labels Jul 26, 2024
@tommasini tommasini requested a review from a team as a code owner July 26, 2024 10:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a8e048
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b78efa66-3b6c-4413-9d78-fd5a07523a2e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@sethkfman sethkfman removed the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 29, 2024
@sethkfman sethkfman merged commit 7792d15 into release/7.28.0 Jul 29, 2024
30 of 32 checks passed
@sethkfman sethkfman deleted the fix/long-press-samsung branch July 29, 2024 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants