Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add events for nft detection #10409

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jul 25, 2024

Description

This PR adds tracking nft_autodetection_enabled events when user is onboarded and when user toggles on/off the nft detection settings.

Related issues

Fixes:

Manual testing steps

  1. Launch app and verify that you see in the logs "NFT Autodetection" event
  2. Go to security settings
  3. Toggle the Nft autodetection toggle on and off and verify that everytime an event is fired with the correct values

Screenshots/Recordings

Before

After

afterEvent.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea96e24
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/850ab96b-279b-48ad-aff9-fd066d14ee74

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review July 25, 2024 16:13
@sahar-fehri sahar-fehri requested a review from a team as a code owner July 25, 2024 16:13
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 802fb14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38d5364f-889b-40bf-b23f-62a92979f091

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 26, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 26, 2024
@sahar-fehri sahar-fehri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 26, 2024
Copy link

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9bb238e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2477b627-d02c-4af1-843a-14fb21276404

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri merged commit 0bc3d25 into main Jul 26, 2024
37 of 38 checks passed
@sahar-fehri sahar-fehri deleted the fix/add-metametrics-for-nft-detection branch July 26, 2024 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants