fix: switch chain with walletconnect

[ignaciosantise]

Description

MetaMask calls updateSession multiple times when the user tries to switch chain from the dapp. This causes the dapp to receive a chainChanged event before receiving the updated session from the wallet.

• Compare addresses in lowercase
• Parse chainId correctly
• Clearing state variables of BackgroundBridge when the session is disconnected
• Bumped walletconnect sdk versions to latest

Related issues

Fixes:

Manual testing steps

1. Go to https://lab.web3modal.com/library/ethers/ with an iPhone
2. Press the "Connect Wallet" button and select "Metamask"
3. Press "Open" to open MetaMask (if applies)
4. Accept the session proposal
5. Go back to the browser
6. Switch chain to Polygon (chain must be Already added as know network in Metamask)
7. Go to MetaMask and accept the switch popup
8. Go back to the browser and see there is a new redirect popup, which causes issues in the Wallet. The popup shouldn't be there

Screenshots/Recordings

Before

RPReplay_Final1721854496.mov

After

mm.solved.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[ignaciosantise]

I have read the CLA Document and I hereby sign the CLA

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@walletconnect/core@2.14.0	environment, network	0	2.59 MB	gancho_walletconnect
npm/@walletconnect/react-native-compat@2.14.0	None	0	26.7 kB	gancho_walletconnect
npm/@walletconnect/se-sdk@1.9.0	None	0	6.58 MB	gancho_walletconnect
npm/@walletconnect/sign-client@2.14.0	None	0	2.71 MB	gancho_walletconnect
npm/@walletconnect/utils@2.14.0	network	0	3.78 MB	gancho_walletconnect
npm/@walletconnect/web3wallet@1.13.0	None	0	3.38 MB	gancho_walletconnect

🚮 Removed packages: npm/@walletconnect/core@2.13.0, npm/@walletconnect/react-native-compat@2.13.0, npm/@walletconnect/se-sdk@1.8.1, npm/@walletconnect/sign-client@2.13.3, npm/@walletconnect/utils@2.13.0, npm/@walletconnect/web3wallet@1.12.3

View full report↗︎

[andreahaku]

LGTM

[enesozturk]

Hey @andreahaku, what are the next steps to get the PRs merged and published? 🙏

[andreahaku]

Hey @andreahaku, what are the next steps to get the PRs merged and published? 🙏

it needs to be QAd by our engineers. When it's done we can merge it. Thanks

[christopherferreira9]

@ignaciosantise
Is it normal that this only works on the first switching?

Screen.Recording.2024-08-14.at.17.19.48.mov

[ignaciosantise]

@christopherferreira9 yes, to receive a new switch event on MM you need to send a request, like Personal Sign.

This is internally handled by the se-sdk.

[ganchoradkov]

@ignaciosantise Is it normal that this only works on the first switching?

Screen.Recording.2024-08-14.at.17.19.48.mov

Hey @christopherferreira9, this is the expected behaviour. The reason why you get prompt to accept the switch initially is because polygon (in this example) is not approved in the session. The wallet receives the request, updates the session with this new chain (polygon) and emits chainChanged event. The switch to ethereum is done only locally since it is already approved in the session. If you change again to polygon, it will be local change as well so you won't receive request in the wallet. If you change to 3rd chain though, you will again get request so the wallet can update the session.

Hope this context helps!

[christopherferreira9]

@ignaciosantise Is it normal that this only works on the first switching?
Screen.Recording.2024-08-14.at.17.19.48.mov

Hey @christopherferreira9, this is the expected behaviour. The reason why you get prompt to accept the switch initially is because polygon (in this example) is not approved in the session. The wallet receives the request, updates the session with this new chain (polygon) and emits chainChanged event. The switch to ethereum is done only locally since it is already approved in the session. If you change again to polygon, it will be local change as well so you won't receive request in the wallet. If you change to 3rd chain though, you will again get request so the wallet can update the session.

Hope this context helps!

Thank you for the reply. iOS and Android look good.
Tested with both deeplink and QR code session for both platforms.

[andreahaku]

LGTM

[sethkfman]

LGTM