Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): add property to provider selected event #10393

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jul 24, 2024

Description

This PR adds the amount property to provider selected event

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1776

Manual testing steps

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jul 24, 2024
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 24, 2024
Copy link
Contributor

github-actions bot commented Jul 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 688b33a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2090cebf-d68e-4226-bc48-4cf8c721db2f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review July 24, 2024 21:39
@wachunei wachunei requested review from a team as code owners July 24, 2024 21:39
@wachunei wachunei added the needs-ramp-qa Tickets that need feature QA on the ramps flows label Jul 24, 2024
@mdoucette-consensys
Copy link

Confirming these changes reflecting the update to the Provider Selected event metrics for Ramps look good to me.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 19, 2024
Copy link

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Aug 19, 2024
@wachunei wachunei merged commit e31aacc into main Aug 19, 2024
38 checks passed
@wachunei wachunei deleted the feat/ramp-analytics-provider-selected-event branch August 19, 2024 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants