chore: Migrate default preference to mmkv

[tommasini]

Description

• Migration for migrate default preference data to mmkv
• Refactor of the default preferences usage across the app

Before (Default Preferences)
{"@MetaMask:MetaMetricsId": "558de5e5-d382-4a9e-9f24-cce477116414", "@MetaMask:analyticsDataRecorded": "true", "@MetaMask:metricsOptIn": "agreed", "@MetaMask:onboardingWizard": "explored"}

After  (MMKV)
 MetaMetricsId 558de5e5-d382-4a9e-9f24-cce477116414
 analyticsDataRecorded true
 metricsOptIn agreed
 onboardingWizard explored

Related issues

Fixes:

Manual testing steps

1. install the app
2. login
3. close onboarding flow
4. update the app with the code on this PR
5. the onboarding flow shouldn't appear

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 66269bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e90e6322-f87d-4e4c-8c66-a46072ec438b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5d51964
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/03f78720-3805-49d5-849c-b6f8af50379c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[andreahaku]

LGTM

[NicolasMassart]

Nice job on this, a lot of places to change indeed.
I commented some issue on the migration unit test as some parts are not testing anything to me (I can be wrong though) and suggested idea to make your migration coverage stronger.

Also I wonder if you could make something to deprecate the DefaultPreferences until we get rid of the dependency. Otherwise we get the risk that it's used again somewhere.
Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
54.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[NicolasMassart]

Looks good to me.
Great work mate!

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0d58b7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/41f14fc9-7307-4d36-9556-086b23193b6f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request