Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attribution link #10365

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix: attribution link #10365

merged 2 commits into from
Jul 24, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jul 22, 2024

Description

  • Update the attribution link to match the current app version.
  • The update-attributions workflow was using a low-privilege token for checking out the repository. The checkout step is what determines which credentials are used upon push. The later step with git push well fail with a HTTP 403 response despite having a token declared with write access, because git push uses the credentials setup during checkout.

Related issues

Fixes: #1829

Manual testing steps

  1. Go toSettings Page.
  2. Scroll down and click on About Metamask.
  3. Click on Attributions.
  4. You should then be redirected to https://raw.githubusercontent.com/MetaMask/metamask-mobile/v7.27.0/attribution.txt (where v7.27.0 is the current Metamask Mobile version)

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-24.at.01.22.44.mp4

After

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-24.at.00.59.05.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested a review from a team July 22, 2024 20:11
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner July 22, 2024 20:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 22, 2024
@cryptodev-2s cryptodev-2s requested a review from Gudahtt July 22, 2024 20:14
Copy link

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you update this PR with manual testing steps, and a recording that shows that this works?

@cryptodev-2s cryptodev-2s requested a review from Gudahtt July 23, 2024 23:22
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit ad806d6 into main Jul 24, 2024
40 checks passed
@cryptodev-2s cryptodev-2s deleted the fix/attribution-link branch July 24, 2024 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.29.0 Issue or pull request that will be included in release 7.29.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants