Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notifications UI components to be used by Views #10363

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Jul 22, 2024

Description

This PR implements the UI pieces (components) that will serve as base layer for Notification's Views/Screen. At this stage, although we're dealing with UI, there's no UI change sort of saying because the components aren't in use by any screen. The screen and final piece of this "break down" effort of PRs will bring all pieces together.

Main PR and visual final result can be seen here

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Jul 22, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jul 22, 2024
@Jonathansoufer Jonathansoufer changed the title Feat/add notifications UI components feat: add notifications UI components to be used by Views Jul 23, 2024
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team and removed team-snaps-platform Snaps Platform team labels Jul 23, 2024
@Jonathansoufer Jonathansoufer marked this pull request as ready for review July 23, 2024 14:46
@Jonathansoufer Jonathansoufer requested review from a team as code owners July 23, 2024 14:46
Copy link
Contributor

github-actions bot commented Jul 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 64af80f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa182c17-dba2-4c5b-8c93-4b4420985807

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.65031% with 100 lines in your changes missing coverage. Please review.

Project coverage is 49.74%. Comparing base (4b9f31c) to head (64af80f).
Report is 27 commits behind head on main.

Files Patch % Lines
app/components/UI/Notification/List/index.tsx 10.86% 40 Missing and 1 partial ⚠️
...ents/UI/Notification/NotificationMenuItem/Root.tsx 46.42% 14 Missing and 1 partial ⚠️
...ents/UI/Notification/SwitchLoadingModal/Loader.tsx 0.00% 11 Missing ⚠️
...yncing/ProfileSyncingModal/ProfileSyncingModal.tsx 62.50% 7 Missing and 2 partials ⚠️
...fication/SwitchLoadingModal/SwitchLoadingModal.tsx 0.00% 7 Missing ⚠️
...ents/UI/Notification/NotificationMenuItem/Icon.tsx 53.84% 3 Missing and 3 partials ⚠️
app/util/notifications/methods/common.ts 16.66% 5 Missing ⚠️
...UI/Notification/SwitchLoadingModal/LoaderModal.tsx 0.00% 4 Missing ⚠️
...pp/components/UI/ProfileSyncing/ProfileSyncing.tsx 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10363      +/-   ##
==========================================
- Coverage   49.78%   49.74%   -0.05%     
==========================================
  Files        1437     1476      +39     
  Lines       34762    35535     +773     
  Branches     3921     4056     +135     
==========================================
+ Hits        17307    17676     +369     
- Misses      16354    16739     +385     
- Partials     1101     1120      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini
Copy link
Contributor

@Jonathansoufer it's seems a lot e2e are failing, can you see what is happening?

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 24, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 24, 2024
@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 24, 2024
@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 24, 2024
Copy link
Contributor

github-actions bot commented Jul 24, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bec53e0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9efd99cb-82c7-4bb4-87f1-3eb06330a172

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 24, 2024
Copy link
Contributor

github-actions bot commented Jul 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6dff4f8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b241995-311c-41c3-bdb6-e280fbe5f1ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jonathansoufer Jonathansoufer merged commit 43a59c0 into main Jul 24, 2024
31 of 32 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-notifications-ui-components branch July 24, 2024 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 24, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants