-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add notifications UI components to be used by Views #10363
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 64af80f Note
|
@Jonathansoufer it's seems a lot e2e are failing, can you see what is happening? |
Bitrise❌❌❌ Commit hash: bec53e0 Note
|
Bitrise✅✅✅ Commit hash: 6dff4f8 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR implements the UI pieces (components) that will serve as base layer for Notification's Views/Screen. At this stage, although we're dealing with UI, there's no UI change sort of saying because the components aren't in use by any screen. The screen and final piece of this "break down" effort of PRs will bring all pieces together.
Main PR and visual final result can be seen here
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist