Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make add-team-label use the reusable workflow #10350

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jul 19, 2024

Description

Instead of copy-pasting the implementation of add-team-label to other repositories, such as metamask-extension and metamask-mobile, it should be possible to call the workflow directly from the github-tools repository, if we make it a reusable workflow. This is great, because if we make a change to the workflow in the github-tools repository, the changes propagate to other repositories as well.

More information about reusable workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows

This kind of aligns with MetaMask/metamask-extension#25509, but not exactly. The shared library would still be needed nevertheless, as this is only sharing the workflow definition, but not the scripts that are run during the workflow. The scripts still need to exist in all the repositories (for now). Ideally, we would make the shared library an npm package that can be installed in the different repositories to allow for the sharing of scripts.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2760

Manual testing steps

  1. Have the workflow run the same as before, without it being defined in the repository.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr itsyoboieltr self-assigned this Jul 19, 2024
@itsyoboieltr itsyoboieltr changed the title feat: add-team-label reusable workflow feat: make add-team-label use the reusable workflow Jul 19, 2024
@itsyoboieltr itsyoboieltr marked this pull request as ready for review July 22, 2024 15:45
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner July 22, 2024 15:45
@itsyoboieltr itsyoboieltr reopened this Jul 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
@itsyoboieltr itsyoboieltr added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 22, 2024
@MetaMask MetaMask unlocked this conversation Jul 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.63%. Comparing base (4b9f31c) to head (9c5120e).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10350      +/-   ##
==========================================
- Coverage   49.78%   49.63%   -0.15%     
==========================================
  Files        1437     1446       +9     
  Lines       34762    35022     +260     
  Branches     3921     3968      +47     
==========================================
+ Hits        17307    17384      +77     
- Misses      16354    16539     +185     
+ Partials     1101     1099       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the investigation on using the hash!

@itsyoboieltr itsyoboieltr merged commit f59d497 into main Jul 26, 2024
32 checks passed
@itsyoboieltr itsyoboieltr deleted the make-add-team-label-reusable-workflow branch July 26, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.29.0 Issue or pull request that will be included in release 7.29.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants