Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: confirmations UI adjustments #10348

Merged
merged 16 commits into from
Sep 11, 2024
Merged

fix: confirmations UI adjustments #10348

merged 16 commits into from
Sep 11, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jul 19, 2024 •
edited
Loading

Description

This PR aims to adjust couple design tweaks reported in the ticket https://github.com/MetaMask/MetaMask-planning/issues/2750

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2750

Manual testing steps

Screenshots/Recordings

Before

old1
old2
old3

After

new1
new2
new3

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 19, 2024
@OGPoyraz OGPoyraz changed the title Add confirmation UI adjustments fix: confirmations UI adjustments Jul 19, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review July 22, 2024 10:08
@OGPoyraz OGPoyraz requested review from a team as code owners July 22, 2024 10:08
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2593372
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5b5fda7-e64d-4f09-a994-b89d32ea066f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ddab5b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/effaa9ae-fbe1-4009-8732-40c86ad7e57e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.5% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarCloud

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 234bd4d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e77f8f4-cdd7-457b-b7ee-03c9a716a471

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6283bf3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3eb8a374-c91e-4323-9872-88188bceed7e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 714145e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c8ac495-0384-4eed-bf61-fd4f94233071

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz force-pushed the fix/confirmation-ui-adjustments branch from 714145e to 5a2d43c Compare September 10, 2024 11:09
@OGPoyraz OGPoyraz force-pushed the fix/confirmation-ui-adjustments branch from 0e1787f to 88667d9 Compare September 11, 2024 08:36
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bcacac2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3b80421-250f-4542-a435-e1e3bfcc6d2c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

matthewwalsh0
matthewwalsh0 previously approved these changes Sep 11, 2024
View reviewed changes
vinistevam
vinistevam previously approved these changes Sep 11, 2024
View reviewed changes
@OGPoyraz OGPoyraz dismissed stale reviews from vinistevam and matthewwalsh0 via 968b910 September 11, 2024 12:54
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 968b910
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/242795a4-e923-4990-9503-9dd92952ca5e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.1% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarCloud

@OGPoyraz OGPoyraz merged commit 7361422 into main Sep 11, 2024
41 of 42 checks passed
@OGPoyraz OGPoyraz deleted the fix/confirmation-ui-adjustments branch September 11, 2024 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinistevam vinistevam vinistevam left review comments

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

Assignees
No one assigned
Labels
release-7.32.0 Issue or pull request that will be included in release 7.32.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OGPoyraz @pedronfigueiredo @matthewwalsh0 @vinistevam @metamaskbot