-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update the 'sendMessage' method in the 'DeeplinkProtocolService' class #10304
chore: update the 'sendMessage' method in the 'DeeplinkProtocolService' class #10304
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…DeeplinkProtocolService'
Quality Gate passedIssues Measures |
Good for iOS and Android using the ReactNative SDK. Test casesGIVEN that a user has a ReactNative SDK dapp installed on iOS GIVEN that a user has a ReactNative SDK dapp installed on Android GIVEN that a user has a ReactNative SDK dapp installed on iOS A the time of testing this PR for android it still returns [null, 0x00..] but it is fixed for ios where the response looks like [0x00..] |
Bitrise✅✅✅ Commit hash: 3dadfe4 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Updated the
sendMessage
method in theDeeplinkProtocolService
class.Changes Made:
chainId
andselectedAccounts
to each sent message.Code Snippet:
This PR addresses several key issues and enhancements:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist