Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ACTIONS_WRITE_TOKEN in attributions workflow #10279

Merged

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jul 10, 2024

Description

This PR replaces the use of GITHUB_TOKEN with ACTIONS_WRITE_TOKEN in attributions workflow, which has the necessary permissions to commit and comment on a PR.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner July 10, 2024 15:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@cryptodev-2s cryptodev-2s added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 10, 2024
@cryptodev-2s cryptodev-2s requested a review from a team July 10, 2024 15:27
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit 74dbb72 into main Jul 10, 2024
44 of 46 checks passed
@cryptodev-2s cryptodev-2s deleted the fix/use-actions-write-token-in-attributions-workflow branch July 10, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants