Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New nft details page #10277

Merged
merged 58 commits into from
Aug 1, 2024
Merged

feat: New nft details page #10277

merged 58 commits into from
Aug 1, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jul 10, 2024 •
edited
Loading

Description

This PR modifies the design of the NFT details page.
Designs: https://www.figma.com/design/TfVzSMJA8KwpWX8TTWQ2iO/Asset-list-and-details?node-id=1242-143952&m=dev

Related issues

Fixes:
Related: MetaMask/core#4522
Related: MetaMask/core#4443

Manual testing steps

  1. Go to this NFT tab
  2. Click and browse through your NFTs
  3. You should be able to see basic things like tokenId, contract address, description. Other fields will be displayed if they exist.
  4. Click on the contract address and you should be redirected to etherscan.
  5. Click on the image in the NFT details page and you should see the image in a new page without any of the details.
  6. Try clicking on the navbar and go to "See on opensea"
  7. Removing NFT flow and Sending NFT flow should not be affected

Screenshots/Recordings

Before

Screen.Recording.2024-07-18.at.16.29.09.mov

After

after.mov

Also we added a new bottom sheet when token ID is too long

Screen.Recording.2024-07-27.at.22.03.22.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 15, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 650b520
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa0421b0-d916-4207-9f80-eede91049062

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

brianacnguyen
brianacnguyen previously approved these changes Jul 30, 2024
View reviewed changes
bergeron
bergeron previously approved these changes Jul 30, 2024
View reviewed changes
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 63719f9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/519c1b0c-1f10-4573-9fd7-655185c35bb1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is awesome, left some questions!

app/components/Views/NftDetails/nftDetails.utils.ts Outdated Show resolved Hide resolved
app/util/url/index.ts Outdated Show resolved Hide resolved
patches/@metamask+assets-controllers+30.0.0.patch Show resolved Hide resolved
app/util/url/index.ts Outdated Show resolved Hide resolved
app/util/url/index.ts Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri dismissed stale reviews from brianacnguyen and bergeron via 7acd85c July 31, 2024 13:43
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7acd85c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c15b433f-7442-4170-81c8-59949d975bd0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's re run the E2E and only merge when they are all green!

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5075db2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2798aa4c-ec8f-4117-99ec-5e278145f856

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jul 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.6% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri merged commit 0c2befd into main Aug 1, 2024
33 checks passed
@sahar-fehri sahar-fehri deleted the feat/NFT-details-new-design branch August 1, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@cortisiko cortisiko cortisiko approved these changes

@bergeron bergeron bergeron approved these changes

@brianacnguyen brianacnguyen brianacnguyen left review comments

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sahar-fehri @bergeron @cortisiko @brianacnguyen @Prithpal-Sooriya @tommasini @metamaskbot