-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Sentry snapshot with masked data #10241
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
The failed quality gate do not seem accurate |
The |
That would mean that I bring that method from extension |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10241 +/- ##
==========================================
+ Coverage 49.50% 49.68% +0.17%
==========================================
Files 1438 1450 +12
Lines 34674 34909 +235
Branches 3853 3950 +97
==========================================
+ Hits 17166 17344 +178
- Misses 16426 16463 +37
- Partials 1082 1102 +20 ☔ View full report in Codecov by Sentry. |
@jpcloureiro Thanks for the review!!!! I believe I addressed/answered everything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedIssues Measures |
Description
This PR introduces snapshot with masked data for metamask mobile.
Here is an example of masked data on sentry
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1843
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist