-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove blockaid env variable #10215
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…k-mobile into blockaid_remove_env_var
Bitrise✅✅✅ Commit hash: 34b9cee Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10215 +/- ##
==========================================
+ Coverage 49.50% 49.67% +0.17%
==========================================
Files 1438 1444 +6
Lines 34674 34728 +54
Branches 3853 3852 -1
==========================================
+ Hits 17166 17252 +86
+ Misses 16426 16396 -30
+ Partials 1082 1080 -2 ☔ View full report in Codecov by Sentry. |
app/components/Views/confirmations/components/BlockaidBanner/BlockaidBanner.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! left a nit pick!
cee37d8
Quality Gate passedIssues Measures |
Description
Remove bloackaid env var from mobile code.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1629
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist