Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog release automation #10172

Merged
merged 44 commits into from
Jul 16, 2024
Merged

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jun 28, 2024

Description

This PR updates the release cut GH action. The action will now generate the changelog from a CSV file of changes between to commits/tag/branches.

The input for this action now takes in a tag from the previous release in-order to base the changes.

The CSV file generate now uses the tag on each PR to assign the work to team for verification.

Related issues

Fixes:

Manual testing steps

  1. Plug this branch into the GH action
  2. Confirm it generates a release branch and csv test file

Screenshots/Recordings

Before

Example output: #10052

After

Example output: #10242

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 28, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/simple-git@3.25.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.51%. Comparing base (ea14ef7) to head (4a2faf5).
Report is 3 commits behind head on main.

Current head 4a2faf5 differs from pull request most recent head b292665

Please upload reports for the commit b292665 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10172   +/-   ##
=======================================
  Coverage   49.50%   49.51%           
=======================================
  Files        1438     1438           
  Lines       34674    34676    +2     
  Branches     3853     3853           
=======================================
+ Hits        17166    17169    +3     
  Misses      16426    16426           
+ Partials     1082     1081    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman marked this pull request as ready for review June 28, 2024 22:16
@sethkfman sethkfman requested review from a team as code owners June 28, 2024 22:16
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review pass, I still have the mjs file to check

.github/workflows/create-release-pr.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Show resolved Hide resolved
scripts/changelog-csv.sh Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
@sethkfman sethkfman requested a review from NicolasMassart July 3, 2024 21:54
NicolasMassart
NicolasMassart previously approved these changes Jul 5, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sethkfman
Copy link
Contributor Author

sethkfman commented Jul 5, 2024

@SocketSecurity ignore npm/simple-git@3.25.0

This is expected to help support the creation of a file.

NicolasMassart
NicolasMassart previously approved these changes Jul 5, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

NicolasMassart
NicolasMassart previously approved these changes Jul 12, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

socket-security bot commented Jul 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@octokit/rest@21.0.0 None +11 1.65 MB octokitbot
npm/simple-git@3.25.0 shell Transitive: filesystem +2 976 kB steveukx

View full report↗︎

@chrisleewilcox chrisleewilcox added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 15, 2024
Copy link
Contributor

github-actions bot commented Jul 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cdf93c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91e37a2e-237c-4cc5-aefa-8ef8cad1d2cf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sethkfman sethkfman merged commit 0ba873a into main Jul 16, 2024
32 checks passed
@sethkfman sethkfman deleted the chore/changelog-release-automation branch July 16, 2024 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants