Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memoize token list #10142

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix: memoize token list #10142

merged 3 commits into from
Jun 28, 2024

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to address performance issue on simulations happens only on mainnet.

Related issues

Manual testing steps

There should be no performance discrepancies for simulations between mainnet and any other network.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner June 27, 2024 14:11
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 27, 2024
digiwand
digiwand previously approved these changes Jun 27, 2024
@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 27, 2024

Works perfectly!
Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/677ffba8-5a0a-4e3b-b7bf-f783da9bba84?tab=artifacts
Samsung S24+, Android 14
iOS 15, iOS version 17.15.1

iOS:

mainnetIos.mov
swapIos.mp4
portfolioIos.mov

Android:

mainnetAndroid.mp4
portfolioAndroid.mov

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Jun 27, 2024
Copy link

@OGPoyraz OGPoyraz merged commit fe986fe into main Jun 28, 2024
32 checks passed
@OGPoyraz OGPoyraz deleted the fix/memoize-token-list branch June 28, 2024 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants