-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memoize token list #10142
Merged
Merged
fix: memoize token list #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
commented
Jun 27, 2024
digiwand
previously approved these changes
Jun 27, 2024
Works perfectly! iOS: mainnetIos.movswapIos.mp4portfolioIos.movAndroid: mainnetAndroid.mp4portfolioAndroid.mov |
OGPoyraz
force-pushed
the
fix/memoize-token-list
branch
from
June 28, 2024 10:35
9f2aebf
to
ac89e10
Compare
matthewwalsh0
approved these changes
Jun 28, 2024
Quality Gate passedIssues Measures |
metamaskbot
added
the
release-7.27.0
Issue or pull request that will be included in release 7.27.0
label
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-7.27.0
Issue or pull request that will be included in release 7.27.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address performance issue on simulations happens only on mainnet.
Related issues
Manual testing steps
There should be no performance discrepancies for simulations between mainnet and any other network.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist