-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve add network fields checkers #10123
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 9f4befd Note
|
5cb9419
to
89c2508
Compare
077eeaa
to
4b32b82
Compare
48a6c58
to
9865eb6
Compare
9865eb6
to
6af4857
Compare
Bitrise✅✅✅ Commit hash: b33b149 Note
|
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 1288ff7 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome!
Description
This PR complete the add custom network Flow
Chain Name and ChainID Match: The system should validate that the chain name provided by the user matches the corresponding network chainId. This can be done by comparing the input against a predefined list of known chain names and their associated chainIds.
Valid rpcURL: The rpcURL provided should be verified against a list of known providers. This ensures that the rpcURL is not only valid but also corresponds to a trusted source.
Unique rpcURL: The system must ensure that the rpcURL provided is not already associated with another added network within the system. This can be achieved by checking the new rpcURL against a database or list of rpcURLs already associated with existing networks.
Unique ChainID and rpcURL Combination: The combination of chainID and rpcURL should be unique and not duplicated in another existing network within the system. This requires a check against existing combinations to ensure no duplicates are allowed.
Suggest Correct Network Name and Symbol: If the network name or symbol provided does not match the expected values (based on the chainId or other validation logic), the system should suggest the correct network name and symbol. This could involve providing a dropdown list of valid names/symbols based on the chainId or implementing a correction suggestion mechanism.
Related issues
Fixes: #10564
Manual testing steps
export MM_NETWORK_UI_REDESIGN_ENABLED="1"
to your.js.env
source .js.env
yarn watch:clean
yarn start:ios
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist