Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stuck after nonce too low error #10049

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to fix send flow after getting nonce too low error.

Related issues

Fixes: #9729

Manual testing steps

  1. Go to send flow
  2. Before send, change it to lower nonce to get error
  3. Get error and see it's redirected to the latest screen you're on
  4. Try send flow again
  5. It should successfully send

Screenshots/Recordings

Before

Forwarded from tests
https://github.com/MetaMask/metamask-mobile/assets/104780023/655e0a17-0768-422b-a337-7909bc560e84

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-20.at.08.52.49.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

@sleepytanya
Copy link
Contributor

Bitrise build https://app.bitrise.io/build/998c80b8-fc0a-4193-9cac-229f25a01a01?tab=artifacts
Samsung S24+, Android 14

Correct nonce transaction can be successfully send after attempt to send low nonce transaction:

normalNonce.mov

High nonce transaction can be successfully send after attempt to send low nonce transaction:

highNonce.mp4

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Jun 21, 2024
@OGPoyraz OGPoyraz merged commit a6fa898 into main Jun 24, 2024
37 checks passed
@OGPoyraz OGPoyraz deleted the 9729-bug-after-attempting-to-send-a-transaction-with-a-low-nonce-any-subsequent-transactions-with-the-correct-nonce-or-a-higher-nonce-result-in-an-error-message-stating-approval-request-with-id-not-found branch June 24, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@metamaskbot metamaskbot added the release-7.27.0 Issue or pull request that will be included in release 7.27.0 label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.27.0 Issue or pull request that will be included in release 7.27.0 team-confirmations Push issues to confirmations team
Projects
None yet
3 participants