Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Keystone and NGRAVE dependencies #10016

Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore: Update Keystone and NGRAVE dependencies #10016

merged 1 commit into from
Aug 30, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 17, 2024

Description

Keystone and NGRAVE dependencies have been updated to their latest patch versions.

Related issues

Closes https://github.com/MetaMask/MetaMask-planning/issues/2043

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security Socket Security
Copy link

socket-security bot commented Jun 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ngraveio/bc-ur@1.1.13 None +6 580 kB xardasss

🚮 Removed packages: npm/@ngraveio/bc-ur@1.1.6

View full report↗︎

@Gudahtt Gudahtt marked this pull request as ready for review June 17, 2024 16:45
@Gudahtt Gudahtt requested a review from a team as a code owner June 17, 2024 16:45
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 17, 2024
@Gudahtt Gudahtt force-pushed the update-keystone-ngrave-dependencies branch from 7671487 to 6494527 Compare June 17, 2024 19:49
@Gudahtt Gudahtt added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6494527
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c6b4938-e74b-4f27-b3c0-7939cb9c3f9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

NicolasMassart
NicolasMassart approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Gudahtt
chore: Update Keystone and NGRAVE dependencies
4ee2ed5 
Keystone and NGRAVE dependencies have been updated to their latest
patch versions.

Closes MetaMask/MetaMask-planning#2043
@Gudahtt Gudahtt force-pushed the update-keystone-ngrave-dependencies branch from 6494527 to 4ee2ed5 Compare August 30, 2024 11:54
@Gudahtt Gudahtt requested review from a team as code owners August 30, 2024 11:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gudahtt Gudahtt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ee2ed5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53d60b97-df18-4d73-ac39-f573aadd48ce

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Gudahtt Gudahtt merged commit 65db18b into main Aug 30, 2024
38 of 39 checks passed
@Gudahtt Gudahtt deleted the update-keystone-ngrave-dependencies branch August 30, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 30, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @NicolasMassart @metamaskbot