Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Error fetching quote when swapping ERC20 to other tokens #9677

Closed
SamuelSalas opened this issue May 17, 2024 · 1 comment
Closed

[BUG] Error fetching quote when swapping ERC20 to other tokens #9677

SamuelSalas opened this issue May 17, 2024 · 1 comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.23.0 release-7.23.0 Issue or pull request that will be included in release 7.23.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps type-bug Something isn't working

Comments

@SamuelSalas
Copy link
Contributor

SamuelSalas commented May 17, 2024 •
edited
Loading

Describe the bug

When selecting a ERC20 token as the From token for swap, after trying to get the quotes, the "Error fetching quote" would be displayed.

Screenshots/Recordings

RPReplay_Final1715950032.mov

Expected behavior

The swipe to swap screen should be displayed and show the quotes.

Steps to reproduce

  1. Tap the swap button from the tab bar actions
  2. Select ERC20 as the from token
  3. Select a native token or another ERC20 token as the to token
  4. Tap Get quotes button
@SamuelSalas SamuelSalas added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.23.0 release-7.23.0 Issue or pull request that will be included in release 7.23.0 type-bug Something isn't working labels May 17, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity May 17, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 17, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label May 17, 2024
@SamuelSalas SamuelSalas added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label May 17, 2024
@nikoferro
Copy link
Contributor

@sethkfman this is solved by #9689

@davibroc davibroc mentioned this issue May 23, 2024
Merged
7 tasks
davibroc added a commit that referenced this issue May 24, 2024
@davibroc
test: Added swap ERC20->ETH test case (#9734)
8ee5376 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

We are adding 1 test case to the smoke test automation that covers
ERC20->ETH swap. Having only ETH->ERC20 poses the risk that we might
miss bugs like this one
#9677

## **Related issues**

## **Manual testing steps**

Run `yarn test:e2e:android:debug:run
e2e/specs/swaps/swap-action-smoke.spec.js`

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team May 29, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity May 29, 2024
@cortisiko cortisiko mentioned this issue Oct 28, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.23.0 release-7.23.0 Issue or pull request that will be included in release 7.23.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-swaps type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@klejeune @nikoferro @sethkfman @SamuelSalas @metamaskbot