Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e iOS Test Failures in Bitrise Regression Pipeline #9513

Closed
9 tasks
Andepande opened this issue May 2, 2024 · 0 comments · Fixed by #9525
Closed
9 tasks

E2e iOS Test Failures in Bitrise Regression Pipeline #9513

Andepande opened this issue May 2, 2024 · 0 comments · Fixed by #9525
Assignees
@salimtb
Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-assets

Comments

@Andepande
Copy link
Member

What is this about?

The failures occur consistently during the iOS test runs in our regression pipeline on Bitrise.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

  • Conduct root cause analysis considering code changes, configurations, and dependencies.
  • Implement fixes to address root cause(s) of iOS test failures.
  • Ensure successful completion of iOS test runs post-fix implementation.
  • Validate effectiveness of fixes to prevent recurrence of failures.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

https://consensys.slack.com/archives/C02U025CVU4/p1714661156997409
@Andepande Andepande assigned salimtb and unassigned salimtb May 2, 2024
@salimtb salimtb mentioned this issue May 3, 2024
Merged
7 tasks
salimtb added a commit that referenced this issue May 3, 2024
@salimtb
fix: fix regression tests (#9525)
0d18471 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR will fix the regression tests

**The issue arose because the keyboard obscured the block explorer
label, which we typically click on to dismiss the keyboard and reveal
the add button. To resolve this, we opted to click on the chainId label
instead.**

check the regression tests
[here](https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e5bafba-ccb2-4fdf-9c50-769b9c4c6e1d?tab=workflows)

## **Related issues**

Fixes: [#9513](#9513)

## **Manual testing steps**

1. Go to bitruse
2. Run regression tests

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 3, 2024
abretonc7s pushed a commit that referenced this issue May 9, 2024
@salimtb @abretonc7s
fix: fix regression tests (#9525)
3453ae0 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR will fix the regression tests

**The issue arose because the keyboard obscured the block explorer
label, which we typically click on to dismiss the keyboard and reveal
the add button. To resolve this, we opted to click on the chainId label
instead.**

check the regression tests
[here](https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e5bafba-ccb2-4fdf-9c50-769b9c4c6e1d?tab=workflows)

## **Related issues**

Fixes: [#9513](#9513)

## **Manual testing steps**

1. Go to bitruse
2. Run regression tests

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salimtb salimtb

Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix regression tests MetaMask/metamask-mobile
3 participants
@salimtb @metamaskbot @Andepande